Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

micro: 2.0.7 -> 2.0.8 #99949

Merged
merged 1 commit into from Oct 28, 2020
Merged

micro: 2.0.7 -> 2.0.8 #99949

merged 1 commit into from Oct 28, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and dtzWill October 7, 2020 12:25
AndersonTorres
AndersonTorres reviewed Oct 8, 2020
View reviewed changes
pkgs/applications/editors/micro/default.nix

goDeps = ./deps.nix;
buildFlagsArray = [ "-ldflags=-s -w -X github.com/zyedidia/micro/v2/internal/util.Version=${version} -X github.com/zyedidia/micro/v2/internal/util.CommitHash=${src.rev}" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit curious. Are these flags something required in new versions of Go?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. Golang uses -ldflags to set variable values at compile time, we use it to set the correct version string, and the -s -w helps to reduce the binary size.
These flags are not required per-se, but if we don't include them, calling micro --version doesn't show the correct version.

@marsam marsam merged commit 5b4331e into NixOS:master Oct 28, 2020
@marsam marsam deleted the update-micro branch October 28, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @AndersonTorres