Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3status-rust: parameterise optional features (pulseaudio, notmuch) #99973

Closed
wants to merge 1 commit into from
Closed

i3status-rust: parameterise optional features (pulseaudio, notmuch) #99973

wants to merge 1 commit into from

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Oct 7, 2020

Motivation for this change

This exposes optional feature flags (withPulseaudio and withNotmuch) as parameters for the package.
The first one was already and is still enabled by default.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Ma27 and globin October 7, 2020 18:54
@pacien pacien force-pushed the i3status-rust_optional-features branch from ca461be to 91c93ac Compare October 7, 2020 19:01
@pacien
Copy link
Contributor Author

pacien commented Nov 9, 2020

Obsoleted by c347482 in #102679.

@pacien pacien closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pacien