Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] tzdata: 2019c -> 2020c #99976

Merged
merged 1 commit into from Oct 20, 2020
Merged

[staging] tzdata: 2019c -> 2020c #99976

merged 1 commit into from Oct 20, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 marked this pull request as ready for review October 7, 2020 19:38
@ajs124 ajs124 requested a review from dtzWill October 7, 2020 20:48
mweinelt
mweinelt approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ajs124
Copy link
Member Author

ajs124 commented Oct 15, 2020

Release notes: https://mm.icann.org/pipermail/tz-announce/2020-October/000059.html

@ajs124
Copy link
Member Author

ajs124 commented Oct 16, 2020

https://mm.icann.org/pipermail/tz-announce/2020-October/000060.html

@ofborg ofborg bot requested a review from fpletz October 17, 2020 00:06
@ajs124 ajs124 changed the title tzdata: 2019c -> 2020b tzdata: 2019c -> 2020c Oct 17, 2020
@mweinelt mweinelt changed the title tzdata: 2019c -> 2020c [staging] tzdata: 2019c -> 2020c Oct 17, 2020
@FRidh FRidh merged commit 8904ce2 into NixOS:staging Oct 20, 2020
@ajs124 ajs124 deleted the upd/tzdata branch October 20, 2020 19:32
@ajs124
Copy link
Member Author

ajs124 commented Oct 22, 2020

Perfect timing, 2020d just got released.

Then again, it only moves DST in Palestine around by a week. Assuming we have any users in that timezone, they'll probably just have to live with that.

@mweinelt
Copy link
Member

mweinelt commented Oct 22, 2020 •
edited

Let's just do the update and not assume where and when our users are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @mweinelt @FRidh