Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

horizon-eda: init at 1.2.1 #99964

Merged
merged 1 commit into from Oct 10, 2020
Merged

horizon-eda: init at 1.2.1 #99964

merged 1 commit into from Oct 10, 2020

Conversation

guserav
Copy link
Contributor

@guserav guserav commented Oct 7, 2020

Mostly based on #86694 by yrashk

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JohnAZoidberg
JohnAZoidberg approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some minor suggestions :)

pkgs/applications/science/electronics/horizon-eda/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/horizon-eda/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/horizon-eda/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/horizon-eda/default.nix Outdated Show resolved Hide resolved
@guserav guserav force-pushed the horizon-eda branch 2 times, most recently from e179189 to 55b71e2 Compare October 9, 2020 17:00
@JohnAZoidberg
Copy link
Member

Evaluation failure on OfBorg is unrelated. See #100089 (comment)

Tested on NixOS and seems to work fine.

@guserav
horizon-eda: init at 1.2.1
6a4c197 
Mostly based on NixOS#86694 by yrashk
@JohnAZoidberg JohnAZoidberg merged commit 384470e into NixOS:master Oct 10, 2020
@JohnAZoidberg JohnAZoidberg deleted the horizon-eda branch October 10, 2020 03:49
@guserav guserav mentioned this pull request Jan 30, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guserav @JohnAZoidberg