Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

physlock: expose option to mute kernel messages when locked #98914

Closed
wants to merge 1 commit into from

Conversation

ghuntley
Copy link
Member

Motivation for this change

https://jlk.fjfi.cvut.cz/arch/manpages/man/physlock.1.en

Enable -m Mute kernel messages on console while physlock is running. in

OPTIONS
-d Fork and detach physlock before prompting for authentication. The parent process returns right after everything is set up, so this option is useful for use in suspend/hibernate scripts.
-h Print brief usage information to standard output and exit.
-l Only lock console switching and exit.
-L Only enable (unlock) console switching and exit. This is useful when a prior instance of physlock has crashed and leaved the console switching mechanism locked.
-m Mute kernel messages on console while physlock is running.
-p MSG
Display MSG before the password prompt.
-s Disable SysRq mechanism while physlock is running.
-v Print version information to standard output and exit.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me. Didn't test the change though.

@stale
Copy link

stale bot commented Apr 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 18, 2021
@ghuntley
Copy link
Member Author

Not stale

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2021
@stale
Copy link

stale bot commented Oct 22, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 22, 2021
@RaitoBezarius
Copy link
Member

Superceded by #199395 ; sorry I missed it while reviewing the PRs…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants