New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/20.09 jetbrains #97477
Merged
worldofpeace
merged 12 commits into
NixOS:release-20.09
from
kolaente:backport/20.09-jetbrains
Sep 8, 2020
Merged
Backport/20.09 jetbrains #97477
worldofpeace
merged 12 commits into
NixOS:release-20.09
from
kolaente:backport/20.09-jetbrains
Sep 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 487ea9d)
(cherry picked from commit 977620b)
(cherry picked from commit 120d6ed)
(cherry picked from commit 7070625)
(cherry picked from commit 1281a57)
(cherry picked from commit 1ae3cac)
(cherry picked from commit d0ce498)
(cherry picked from commit b5a8a3b)
(cherry picked from commit 2fa77fe)
(cherry picked from commit fe552e4)
(cherry picked from commit 7b46916)
(cherry picked from commit ee939c9)
This was referenced Sep 8, 2020
Merged
Hi, just want to mention that the commits didn't match the contribution guidelines exactly.
Just something to keep in mind for the future 👍 |
Oh thanks for the heads up, somehow that's gone missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport of #97359
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)