Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/20.09 jetbrains #97477

Merged
merged 12 commits into from Sep 8, 2020

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Sep 8, 2020

Motivation for this change

Backport of #97359

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Hi, just want to mention that the commits didn't match the contribution guidelines exactly.
For example, they should have been formatted like

jetbrains.webstorm: 2020.2 -> 2020.2.1

Just something to keep in mind for the future 👍

@worldofpeace worldofpeace merged commit 3369f09 into NixOS:release-20.09 Sep 8, 2020
@kolaente
Copy link
Member Author

kolaente commented Sep 9, 2020

Oh thanks for the heads up, somehow that's gone missing.

@kolaente kolaente deleted the backport/20.09-jetbrains branch September 9, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants