Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mpd: fix not properly testing for songs to be in the playlist #97449

Merged
merged 1 commit into from Jan 18, 2021

Conversation

AberDerBart
Copy link

Motivation for this change

Before, when checking if files are in the playlist, mpc listall was used, which actually does not list the playlist, but all files in the library. Now the proper command mpc playlist is used.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AberDerBart
Copy link
Author

@emmanuelrosa please review.

@worldofpeace
Copy link
Contributor

@ofborg test mpd

@worldofpeace
Copy link
Contributor

If I don't get back to you when the check is finished please ping me.

@AberDerBart
Copy link
Author

@worldofpeace ping

@SuperSandro2000 SuperSandro2000 merged commit 4eccd6f into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants