Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmd: relax ld purity check for checkPhase #97453

Merged
merged 1 commit into from Sep 8, 2020
Merged

dmd: relax ld purity check for checkPhase #97453

merged 1 commit into from Sep 8, 2020

Conversation

midchildan
Copy link
Member

Motivation for this change

Fix #97420

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@midchildan
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Sep 8, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Sep 8, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@worldofpeace
Copy link
Contributor

@ofborg eval
@ofborg build dmd

@worldofpeace
Copy link
Contributor

Could u link the issue above and show why we have to disable purity check?

@ofborg ofborg bot requested a review from lionello September 8, 2020 15:44
@midchildan
Copy link
Member Author

Done :-)

@worldofpeace worldofpeace merged commit aeda8fe into NixOS:master Sep 8, 2020
@midchildan midchildan deleted the fix/dmd branch September 8, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@lionello lionello Awaiting requested review from lionello

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tilix doesn't build
2 participants
@midchildan @worldofpeace