Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] palemoon: Add libpulseaudio to wrapper #97442

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Sep 8, 2020

Backport of #97293

Motivation for this change

Tl;dr, palemoon can't find libpulse.so at runtime, magically causing multiple problems down the line. libpulseaudio isn't "registered as an ELF dependency" (excuse my lack of technical specifics), it's dynamically loaded akin to the ffmpeg libs.

Before-After screenshots from pavucontrol:

Bildschirmfoto_2020-09-05_13-41-47
Bildschirmfoto_2020-09-05_13-43-07

To comply with upstream's requirements, fix the missing dependency by adding libpulseaudio to the wrapper.

Things done

Added libpulseaudio to the wrapper.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OPNA2608 OPNA2608 force-pushed the backport-20.03-palemoon-wrapping-libpulseaudio branch from 7c500f6 to d397c6a Compare September 8, 2020 14:05
@ofborg ofborg bot requested a review from AndersonTorres September 8, 2020 14:55
@worldofpeace worldofpeace merged commit e75598b into NixOS:release-20.03 Sep 8, 2020
@OPNA2608 OPNA2608 deleted the backport-20.03-palemoon-wrapping-libpulseaudio branch September 27, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants