Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skktools: 1.3.3 -> 1.3.4 #97424

Merged
merged 2 commits into from Sep 10, 2020
Merged

skktools: 1.3.3 -> 1.3.4 #97424

merged 2 commits into from Sep 10, 2020

Conversation

cohei
Copy link
Contributor

@cohei cohei commented Sep 8, 2020 •
edited

Motivation for this change

To update skktools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cohei cohei marked this pull request as ready for review September 8, 2020 06:18
marsam
marsam reviewed Sep 8, 2020
View reviewed changes
pkgs/tools/inputmethods/skk/skktools/default.nix Outdated
@@ -10,12 +10,12 @@
# Probably, shall package the newer tools as skktools-extra in the future.
stdenv.mkDerivation {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stdenv.mkDerivation {
stdenv.mkDerivation rec {

pkgs/tools/inputmethods/skk/skktools/default.nix Outdated
src = fetchFromGitHub {
owner = "skk-dev";
repo = "skktools";
rev = "c8816fe720604d4fd79f3552e99e0430ca6f2769";
sha256 = "11v1i5gkxvfsipigc1w1m16ijzh85drpl694kg6ih4jfam1q4vdh";
rev = "a203f981a046d8636602b2b5a2867de984daa1b1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "a203f981a046d8636602b2b5a2867de984daa1b1";
rev = "skktools-${stdenv.lib.replaceStrings ["."] ["_"] version}";

@marsam marsam merged commit 5985b5c into NixOS:master Sep 10, 2020
@cohei cohei deleted the update-skktools branch September 10, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cohei @marsam