Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] allegro: fix build, use texinfo6_5 #97459

Merged
merged 1 commit into from Sep 8, 2020
Merged

[20.09] allegro: fix build, use texinfo6_5 #97459

merged 1 commit into from Sep 8, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 8, 2020 •
edited

Motivation for this change

backport of #97432

closes #97458

ZHF: #97479

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
allegro: fix build, use texinfo6_5
bbcbe9e 
(cherry picked from commit cceb63f)
@jonringer
Copy link
Contributor Author

jonringer commented Sep 8, 2020 •
edited

All of these are broken currently, and they are also marked broken... not sure why they are in "failed builds":

https://github.com/NixOS/nixpkgs/pull/97459
2 packages failed to build:
fakenes liquidwar5

8 packages built:
allegro atanks cgui dumb garden-of-coloured-lights lutris lutris-free racer

@jonringer jonringer changed the title allegro: fix build, use texinfo6_5 [20.09] allegro: fix build, use texinfo6_5 Sep 8, 2020
@pbogdan
Copy link
Member

pbogdan commented Sep 8, 2020

I know this is a backport but FYI I found a patch in Fedora that fixes the build issue without needing older texinfo.

@ofborg ofborg bot requested a review from 7c6f434c September 8, 2020 15:58
@jonringer
Copy link
Contributor Author

@pbogdan yea, it should be upstreamed to allegro ideally, and then we just bump the version. However, I'm not sure how active allegro4 is in development.

@jonringer jonringer merged commit ce77f2d into NixOS:release-20.09 Sep 8, 2020
@jonringer jonringer deleted the backport-allegro branch September 8, 2020 17:25
@jonringer jonringer mentioned this pull request Sep 8, 2020
Closed
@pbogdan pbogdan mentioned this pull request Sep 12, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @pbogdan