Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis is always downloading master revision when executing tests. #48

Closed
kamilrakoczy opened this issue Sep 8, 2020 · 4 comments
Closed

Comments

@kamilrakoczy
Copy link
Contributor

Travis is using tuttest to test tutorial commands in the README.md.

Tuttest is following commands from the README.md and make sure they are working.
In the README.md there is a command that is cloning repository and entering newly cloned repository:

git clone https://github.com/SymbiFlow/symbiflow-examples && cd symbiflow-examples

this means, that when someone opens PR, changes from this PR are not reflected in the tests. Always master version of the repository is used in tests.

@litghost
Copy link
Contributor

@tcal-x encountered this too, my suggestion to fix it is #50 (comment)

@tcal-x
Copy link
Contributor

tcal-x commented Sep 21, 2020

@kamilrakoczy -- if you have not started on the fixes suggested in Keith's comment, or plan to start soon, I'll take a whack at it.

@kamilrakoczy
Copy link
Contributor Author

@tcal-x No, I didn't started this, feel free to fix this.

litghost added a commit that referenced this issue Sep 24, 2020
Attempt to roll tarball and Yosys packages for symbiflow-examples.  Name the code blocks.   Address issue #48.
@litghost
Copy link
Contributor

This was fixed in #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants