mypaint: fix crash without hicolor-icon-theme #97416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Mypaint should probably run without having a specific icon theme installed (GNOME's Adwaita, KDE's whatever, or something else should be fine).
But it does not seem to be the case and it looks like it is checking for a presence of
hicolor-icon-theme
:env XDG_DATA_DIRS= $(nix-build -A mypaint --no-out-link)/bin/mypaint
was brokenenv XDG_DATA_DIRS=$(nix-build -A hicolor-icon-theme --no-out-link)/share $(nix-build -A mypaint --no-out-link)/bin/mypaint
workedLet's add it to the closure unconditionally, since it is just an empty directory tree and weights almost nothing.
Noticed by @sikmir in #54677 (comment)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)