Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypaint: fix crash without hicolor-icon-theme #97416

Merged
merged 1 commit into from Sep 8, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 8, 2020

Motivation for this change

Mypaint should probably run without having a specific icon theme installed (GNOME's Adwaita, KDE's whatever, or something else should be fine).
But it does not seem to be the case and it looks like it is checking for a presence of hicolor-icon-theme:

  • env XDG_DATA_DIRS= $(nix-build -A mypaint --no-out-link)/bin/mypaint was broken
  • env XDG_DATA_DIRS=$(nix-build -A hicolor-icon-theme --no-out-link)/share $(nix-build -A mypaint --no-out-link)/bin/mypaint worked

Let's add it to the closure unconditionally, since it is just an empty directory tree and weights almost nothing.

Noticed by @sikmir in #54677 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mypaint seems to check for a presence of this theme scaffold and crashes when not present.
Let’s add this since it weights almost nothing.
@sikmir
Copy link
Member

sikmir commented Sep 8, 2020

It works now!

@jtojnar jtojnar merged commit 26f8b20 into NixOS:master Sep 8, 2020
@jtojnar jtojnar deleted the mypaint-hicolor branch September 8, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants