New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keysmith: replace hardcoded qt prefixes #97468
Conversation
Pinging maintainer @SCOTT-HAMILTON |
makeWrapper $out/bin/.org.kde.keysmith-wrapped $out/bin/org.kde.keysmith \ | ||
--set QML2_IMPORT_PATH "${lib.getLib kirigami2}/lib/qt-5.12.7/qml:${lib.getBin qtquickcontrols2}/lib/qt-5.12.7/qml:${lib.getBin qtdeclarative}/lib/qt-5.12.7/qml:${qtgraphicaleffects}/lib/qt-5.12.7/qml" \ | ||
--set QT_PLUGIN_PATH "${lib.getBin qtbase}/lib/qt-5.12.7/plugins" | ||
--set QML2_IMPORT_PATH "${lib.getLib kirigami2}/${qtbase.qtQmlPrefix}:${lib.getBin qtquickcontrols2}/${qtbase.qtQmlPrefix}:${lib.getBin qtdeclarative}/${qtbase.qtQmlPrefix}:${qtgraphicaleffects}/${qtbase.qtQmlPrefix}" \ | ||
--set QT_PLUGIN_PATH "${lib.getBin qtbase}/${qtbase.qtPluginPrefix}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be needed anymore, because qt's mkDerivaiton
automatically adds wrapQtAppsHook
which will make a wrapper with these entries (as long as they're in buildInputs`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did wonder why this was the only package doing this (and why I couldn't actually get the package to fail). Do we just remove the whole postInstall
section then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some people couldn't run it on WM setup. This didn't fixed it but I kept it in case of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Thra11 It's likely an artifact of older packaging, because the wrappers for qt are relatively new.
@Thra11 please fix the merge conflict. |
The relevant parts got removed. Closing. |
Motivation for this change
The keysmith package refers explicitly to Qt 5.12.7 in prefixes, but is now being built with Qt 5.14. I believe this change should mean that the prefixes will always match the Qt version which it is being built against.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)