pcsctools: use the local smartcard list #97440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhoeg
force-pushed
the
f/pcsctools
branch
from
74670d2
to
3faec1d
Compare
peterhoeg
changed the title
peterhoeg
force-pushed
the
f/pcsctools
branch
from
3faec1d
to
c77d04b
Compare
ofborg
bot
added
11.by: package-maintainer
10.rebuild-linux: 1001-2500
and removed
10.rebuild-linux: 501-1000
labels
Comment on lines
27
to
33
| ] | ||
| ++ stdenv.lib.optionals stdenv.isLinux [ | ||
| "--enable-ipcdir=/run/pcscd" | ||
| "--enable-polkit" | ||
| "--with-systemdsystemunitdir=${placeholder "bin"}/lib/systemd/system" | ||
| ] | ||
| ++ stdenv.lib.optional (!stdenv.isLinux) |
There was a problem hiding this comment.
Suggested change
| ] | |
| ++ stdenv.lib.optionals stdenv.isLinux [ | |
| "--enable-ipcdir=/run/pcscd" | |
| "--enable-polkit" | |
| "--with-systemdsystemunitdir=${placeholder "bin"}/lib/systemd/system" | |
| ] | |
| ++ stdenv.lib.optional (!stdenv.isLinux) | |
| ] ++ stdenv.lib.optionals stdenv.isLinux [ | |
| "--enable-ipcdir=/run/pcscd" | |
| "--enable-polkit" | |
| "--with-systemdsystemunitdir=${placeholder "bin"}/lib/systemd/system" | |
| ] ++ stdenv.lib.optional (!stdenv.isLinux) |
Comment on lines
53
to
54
| ] | ||
| ++ stdenv.lib.optionals stdenv.isLinux [ dbus polkit systemd ] |
There was a problem hiding this comment.
Suggested change
| ] | |
| ++ stdenv.lib.optionals stdenv.isLinux [ dbus polkit systemd ] | |
| ] ++ stdenv.lib.optionals stdenv.isLinux [ dbus polkit systemd ] |
|
Can you please target staging? |
peterhoeg
changed the title
Use the local file provided with pcsctools or alternatively look in /etc/pcsc.
Comment on lines
9
to
11
| , polkit ? null | ||
| , systemd ? null | ||
| , IOKit ? null |
There was a problem hiding this comment.
Suggested change
| , polkit ? null | |
| , systemd ? null | |
| , IOKit ? null | |
| , polkit | |
| , systemd | |
| , IOKit |
If we get any error here than we did something wrong and darwin will be broken because something is null.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Use the local file provided with pcsctools or alternatively look in /etc/pcsc.
There is some noise from nixpkgs-fmt, so it's easier to read like this
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)