[blink][web_tests] document-write tests cleanup #25430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 8, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2397696
branch
3 times, most recently
from
74ffb9f
to
63d9875
Compare
- Add better assertion failure messages - Use better content for document.write The tests assume that the ignore-destructive-writes counter is only incremented during the synchronous part of module evaluation (see whatwg/html#4352 (comment)). This also fixes document-write/module-delayed.html which accidentally had wrong test expectations checked in that made it pass. Bug: 1127215 Bug: 1022182 Bug: v8:9344 Change-Id: I01a75534f7efd0bd8e376dfd049432e52661604d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397696 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807384}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2397696
branch
from
63d9875
to
fe5d12b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests assume that the ignore-destructive-writes counter is only
incremented during the synchronous part of module evaluation (see
whatwg/html#4352 (comment)).
This also fixes document-write/module-delayed.html which accidentally
had wrong test expectations checked in that made it pass.
Bug: 1127215
Bug: 1022182
Bug: v8:9344
Change-Id: I01a75534f7efd0bd8e376dfd049432e52661604d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397696
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807384}