Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-2.gnome_mime_data: Move intltool to nativeBuildInputs #97436

Merged
merged 1 commit into from Dec 29, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Sep 8, 2020

Motivation for this change

Fixes issues with cross-compiling.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Sep 8, 2020

@GrahamcOfBorg build gome2.gnome_mime_data
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.gome2.gnome_mime_data

@kampka kampka added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Sep 8, 2020
@FRidh
Copy link
Member

FRidh commented Sep 8, 2020

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.gnome2.gnome_mime_data

@worldofpeace
Copy link
Contributor

I'm not sure what's up with ofborg but this should at most rebuild two things, like these packages are up for removal anyways.

@kampka
Copy link
Contributor Author

kampka commented Sep 8, 2020

I'm not sure what's up with ofborg but this should at most rebuild two things, like these packages are up for removal anyways.

I'm all up for removing these, but right now they are being pulled in by openjdk which is a rather popular dependency.

@SuperSandro2000
Copy link
Member

@ofborg eval

@FRidh FRidh merged commit 9e043f4 into NixOS:staging Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants