Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drawpile: fix build #97437

Merged
merged 1 commit into from Sep 9, 2020
Merged

drawpile: fix build #97437

merged 1 commit into from Sep 9, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Sep 8, 2020 •
edited

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz fgaz changed the title drawpile: fix build with -fpermissive drawpile: fix build Sep 9, 2020
@worldofpeace
Copy link
Contributor

@fgaz It would be helpful to link to the failing job

@worldofpeace
Copy link
Contributor

Yep, I'm seeing the failure

/nix/store/iygzjy14i075hkxr2gq8cpfjvk2rkx0b-binutils-2.31.1/bin/ld: cannot find -lsecret-1
collect2: error: ld returned 1 exit status
make[2]: *** [src/desktop/CMakeFiles/drawpile.dir/build.make:1585: bin/drawpile-2.1.17] Error 1
make[1]: *** [CMakeFiles/Makefile2:513: src/desktop/CMakeFiles/drawpile.dir/all] Error 2
make: *** [Makefile:149: all] Error 2
error: --- Error --------------------------------------------------------------------------------------------------------------------------------------------------- nix-build
error: --- Error --- nix-daemon
builder for '/nix/store/lhp8rsv75n0kkhkw0wlsmz1cns1qbqq4-drawpile-2.1.17.drv' failed with exit code 2; last 10 log lines:
  [ 99%] Building CXX object src/desktop/CMakeFiles/drawpile.dir/bundled/QtColorWidgets/color_names.cpp.o
  [ 99%] Building CXX object src/desktop/CMakeFiles/drawpile.dir/qrc_color_widgets.cpp.o
  [ 99%] Building CXX object src/desktop/CMakeFiles/drawpile.dir/qrc_cursors.cpp.o
  [100%] Building CXX object src/desktop/CMakeFiles/drawpile.dir/qrc_builtin.cpp.o
  [100%] Linking CXX executable ../../bin/drawpile
  /nix/store/iygzjy14i075hkxr2gq8cpfjvk2rkx0b-binutils-2.31.1/bin/ld: cannot find -lsecret-1
  collect2: error: ld returned 1 exit status
  make[2]: *** [src/desktop/CMakeFiles/drawpile.dir/build.make:1585: bin/drawpile-2.1.17] Error 1
  make[1]: *** [CMakeFiles/Makefile2:513: src/desktop/CMakeFiles/drawpile.dir/all] Error 2

tbh this should fail a lot earlier with CMake. Perhaps a bug could be filed?

@worldofpeace worldofpeace merged commit 5a35396 into NixOS:master Sep 9, 2020
@fgaz fgaz deleted the drawpile/fpermissive branch September 9, 2020 15:47
@fgaz
Copy link
Member Author

fgaz commented Sep 14, 2020 •
edited

I'll report it upstream
edit: drawpile/Drawpile#929

@fgaz fgaz mentioned this pull request Sep 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @worldofpeace