Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/20.03 jetbrains #97474

Closed
wants to merge 12 commits into from

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Sep 8, 2020

Motivation for this change

Backport of #97359

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kolaente
Copy link
Member Author

kolaente commented Sep 8, 2020

It looks like jetbrains mps isn't yet in stable thats why my cherry pick added it 🤔

@kolaente
Copy link
Member Author

kolaente commented Sep 8, 2020

@Ma27 Okay so I just noticed I had built this on 20.03 and not 20.09, let me fix that

@kolaente kolaente mentioned this pull request Sep 8, 2020
10 tasks
@kolaente
Copy link
Member Author

kolaente commented Sep 8, 2020

Replaced by #97477

@kolaente kolaente closed this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant