isso: fix build, switch to python 3, add a test #97435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/marvin opt-in |
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
jonringer
reviewed
Sep 9, 2020
Comment on lines
+20
to
+49
| patches = [ | ||
| # https://github.com/jelmer/isso/commit/e2cfd6c08c0fbe64aedac22b17d30e7a8834cd5b | ||
| (fetchpatch { | ||
| name = "python-3.7-support"; | ||
| url = "https://github.com/jelmer/isso/commit/e2cfd6c08c0fbe64aedac22b17d30e7a8834cd5b.patch"; | ||
| sha256 = "0rgwv6d9q2zdrdkswzdz637xsfbz9405g9shydk7zjcz1km53s4q"; | ||
| }) | ||
|
|
||
| # https://github.com/posativ/isso/issues/611 | ||
| # https://github.com/posativ/isso/pull/614 | ||
| (fetchpatch { | ||
| name = "werkzeug-1-compatibility"; | ||
| url = "https://github.com/posativ/isso/pull/614.patch"; | ||
| sha256 = "082wcsqbn1kc0p2mqb1svz4pj5yxqj0ymq6aqxs57g9ryigwr6sz"; | ||
| }) | ||
|
|
||
| # https://github.com/posativ/isso/pull/615 | ||
| (fetchpatch { | ||
| name = "python-3.8-support"; | ||
| url = "https://github.com/posativ/isso/pull/615.patch"; | ||
| sha256 = "0pwws93ginlf8scnaawqarhbf8dklx1rjsa4kna68bq3lp84bh70"; | ||
| }) | ||
|
|
||
| # https://github.com/posativ/isso/issues/659 | ||
| # https://github.com/posativ/isso/pull/660 | ||
| (fetchpatch { | ||
| name = "flask-caching-fix"; | ||
| url = "https://github.com/posativ/isso/pull/660.patch"; | ||
| sha256 = "09jgd28ldf2zhmg83fjwrimfn97pvcd5fnssi4241gd7z8dafi58"; | ||
| }) |
There was a problem hiding this comment.
at this point, should we just bump to unstable?
There was a problem hiding this comment.
Well, the patches I applied are internal and quite small, and there's a lot more than that between 0.12.2 and master. Yes, it's minor stuff, but still I'd rather keep it stable and wait for a release for now.
There was a problem hiding this comment.
Of course if you prefer we can bump to unstable
|
#97717 was merged, I think this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixing my packages before the 20.09 branch-off
edit: the branch-off happened
ZHF: #97479
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)