Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portfolio: 0.47.0 -> 0.48.0 #96894

Merged
merged 1 commit into from Sep 1, 2020
Merged

portfolio: 0.47.0 -> 0.48.0 #96894

merged 1 commit into from Sep 1, 2020

Conversation

oyren
Copy link
Contributor

@oyren oyren commented Sep 1, 2020

Motivation for this change

Update portfolio to 0.48.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from elohmeier September 1, 2020 09:25
@mweinelt
Copy link
Member

mweinelt commented Sep 1, 2020

Builds and runs. LGTM.

Result of nixpkgs-review pr 96894 1

1 package built:
- portfolio

@mweinelt mweinelt merged commit 918c934 into NixOS:master Sep 1, 2020
@oyren oyren deleted the portfolio-0-48 branch September 2, 2020 20:32
@Pamplemousse Pamplemousse mentioned this pull request Mar 11, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@elohmeier elohmeier Awaiting requested review from elohmeier

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oyren @mweinelt