Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/android studio beta #96874

Merged
merged 2 commits into from Sep 1, 2020
Merged

Update/android studio beta #96874

merged 2 commits into from Sep 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 31, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Aug 31, 2020

This replaces the beta package maintainer with me. As requested by galagora in #96573.

Build was tested by building a small application and running in the emulator.

I used a base64 sha256 in this commit, because I am using nix flakes and that is what it outputs.
I saw NixOS/nix#3786 which refers to #89476, which if I interpret correctly allows base64 sha256 hashes in nixpkgs master now.

@ghost
Copy link
Author

ghost commented Sep 1, 2020

@primeos

@primeos primeos merged commit 7ebcaec into NixOS:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants