Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: make sure the default opacity of ::placeholder is 1 #25310

Merged
merged 1 commit into from Sep 17, 2020
Merged

HTML: make sure the default opacity of ::placeholder is 1 #25310

merged 1 commit into from Sep 17, 2020

Conversation

karlcow
Copy link
Contributor

@karlcow karlcow commented Sep 1, 2020

This test relates to the opacity difference in between Gecko, Blink and WebKit as mentioned by @fvsch

/* Gecko style */
::placeholder {
  color: inherit;
  opacity: 0.54;
}

/* WebKit style */
::placeholder {
  color: #9a9a9a;
  opacity: 1;
}

/* Blink style */
::placeholder {
  color: #757575;
  opacity: 1;
}

See whatwg/html#2561 (comment)
and https://codepen.io/webcompat/pen/bWEEJv

@wpt-pr-bot wpt-pr-bot added the html label Sep 1, 2020
@karlcow karlcow mentioned this pull request Sep 1, 2020
Open
@domenic
Copy link
Member

domenic commented Sep 1, 2020

I think it'd be better to test this using CSSOM?

Regardless, we can't merge this as-is since it's not covered by any spec. But we could rename it to -tentative, and add a link to the spec discussion.

@karlcow
Copy link
Contributor Author

karlcow commented Sep 1, 2020

@domenic happy to do the modifications, do you have an example of something similar done with CSSOM? Thanks

@domenic
Copy link
Member

domenic commented Sep 2, 2020

Basically test getComputedStyle(el, "::placeholder").opacity.

@karlcow
Copy link
Contributor Author

karlcow commented Sep 10, 2020

ok locally this is working.

Capture d’écran 2020-09-10 à 15 12 11

@karlcow
Copy link
Contributor Author

karlcow commented Sep 10, 2020

@domenic is it closer from what you wanted?

@jgraham jgraham closed this Sep 10, 2020
@jgraham jgraham reopened this Sep 10, 2020
domenic
domenic reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Sorry for the delay; I was OOO last week.

Last change: use .tentative instead of -tentative, per http://web-platform-tests.org/writing-tests/file-names.html?highlight=tentative.

@karlcow
Copy link
Contributor Author

karlcow commented Sep 17, 2020

@domenic thanks. ok done.

@domenic domenic merged commit a5d0e1a into web-platform-tests:master Sep 17, 2020
@karlcow karlcow deleted the placeholder-opacity branch January 17, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@annevk annevk Awaiting requested review from annevk

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zcorpan zcorpan Awaiting requested review from zcorpan

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@zqzhang zqzhang

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@karlcow @domenic @jgraham @zqzhang @wpt-pr-bot