Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beets: Fix wavpack mediafile test #96886

Merged
merged 1 commit into from Sep 6, 2020
Merged

beets: Fix wavpack mediafile test #96886

merged 1 commit into from Sep 6, 2020

Conversation

doronbehar
Copy link
Contributor

Extend mutagen-1.43.patch to include a fix for now supported bitrate of
wavpack files. See
beetbox/mediafile@d2fc3b5
for upstream's version of the change.

Motivation for this change

Make beets build / fix tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
beets: Fix wavpack mediafile test
7efe1cf 
Extend mutagen-1.43.patch to include a fix for now supported bitrate of
wavpack files. See
beetbox/mediafile@d2fc3b5
for upstream's version of the change.
@doronbehar doronbehar mentioned this pull request Sep 1, 2020
Closed
10 tasks
@gebner gebner merged commit 91ad566 into NixOS:master Sep 6, 2020
@gebner gebner mentioned this pull request Sep 6, 2020
Closed
10 tasks
@doronbehar doronbehar deleted the pkg/beets/wv-test-fix branch December 18, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @gebner