deepin: register removal in release notes, aliases and module list #96879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
reviewed
Sep 1, 2020
| <link xlink:href="https://www.deepin.org/en/dde/">Deepin Desktop Environment (DDE)</link>, | ||
| including libraries, tools and applications, but still missing a | ||
| service to lauch the desktop environment. It has shown to be a | ||
| difficult task to complete, as discussed in |
There was a problem hiding this comment.
It has shown to no longer be a feasible goal due to reasons discussed in-
I think that's the more definitive conclusion to why we removed it.
worldofpeace
reviewed
Sep 1, 2020
pkgs/top-level/aliases.nix
Outdated
| @@ -104,6 +104,7 @@ mapAliases ({ | |||
| deadbeef-mpris2-plugin = deadbeefPlugins.mpris2; # added 2018-02-23 | |||
| deadpixi-sam = deadpixi-sam-unstable; | |||
| debian_devscripts = debian-devscripts; # added 2016-03-23 | |||
| deepin = throw "deepin was a work in progress and it has been canceled and removed"; # added 2020-08-31 | |||
There was a problem hiding this comment.
Suggested change
| deepin = throw "deepin was a work in progress and it has been canceled and removed"; # added 2020-08-31 | |
| deepin = throw "deepin was a work in progress and it has been canceled and removed https://github.com/NixOS/nixpkgs/issues/94870"; # added 2020-08-31 |
|
Everything else looks good, thanks 👍 |
|
😿 wah the release notes always conflict. |
|
Rebased. |
|
Thanks @romildo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Deepin has been removed in PR #96610 without using
mkRemovedOptionModuleThis PR adds these information.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)