Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocrmypdf: 10.3.0 -> 11.0.1; pdfminer_six: 20200720 -> 20200726 #96876

Merged
merged 2 commits into from Aug 31, 2020
Merged

ocrmypdf: 10.3.0 -> 11.0.1; pdfminer_six: 20200720 -> 20200726 #96876

merged 2 commits into from Aug 31, 2020

Conversation

ivan
Copy link
Member

@ivan ivan commented Aug 31, 2020

Motivation for this change

This fixes the ocrmypdf build on master, which currently fails with:

ERROR: Could not find a version that satisfies the requirement img2pdf<0.4,>=0.3.0 (from ocrmypdf==10.3.0) (from versions: none)
ERROR: No matching distribution found for img2pdf<0.4,>=0.3.0 (from ocrmypdf==10.3.0)
builder for '/nix/store/1ggj5wwl92xickc7w5hfl3zrjfscxnf1-ocrmypdf-10.3.0.drv' failed with exit code 1
error: build of '/nix/store/1ggj5wwl92xickc7w5hfl3zrjfscxnf1-ocrmypdf-10.3.0.drv' failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested the build and ocrmypdf seems to run fine on NixOS.

Note that the ocrmypdf tests require a lot of memory.

cc ocrmypdf maintainer @Kiwi and pdfminer_six maintainers @PsyanticY @marsam

@ivan
pythonPackages.pdfminer_six: 20200720 -> 20200726
dc9f1d6 
ocrmypdf 11.0.1 requires pdfminer_six 20200726
@ivan
ocrmypdf: 10.3.0 -> 11.0.1
243078e 
This fixes the build:

```
ERROR: Could not find a version that satisfies the requirement img2pdf<0.4,>=0.3.0 (from ocrmypdf==10.3.0) (from versions: none)
ERROR: No matching distribution found for img2pdf<0.4,>=0.3.0 (from ocrmypdf==10.3.0)
builder for '/nix/store/1ggj5wwl92xickc7w5hfl3zrjfscxnf1-ocrmypdf-10.3.0.drv' failed with exit code 1
error: build of '/nix/store/1ggj5wwl92xickc7w5hfl3zrjfscxnf1-ocrmypdf-10.3.0.drv' failed
```
@ofborg ofborg bot requested review from marsam, Kiwi and PsyanticY August 31, 2020 23:42
jonringer
jonringer approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96876 1

1 package marked as broken and skipped:
  • invoice2data
8 packages built:
  • kmymoney
  • ocrmypdf
  • pdfminer (python38Packages.pdfminer)
  • python37Packages.pdfminer
  • python37Packages.pdfx
  • python37Packages.weboob
  • python38Packages.pdfx
  • python38Packages.weboob

@jonringer jonringer merged commit d56da56 into NixOS:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@marsam marsam Awaiting requested review from marsam

@Kiwi Kiwi Awaiting requested review from Kiwi

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @jonringer