Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glibmm: Add glib to nativeBuildInputs #96911

Merged
merged 1 commit into from Sep 2, 2020
Merged

glibmm: Add glib to nativeBuildInputs #96911

merged 1 commit into from Sep 2, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Sep 1, 2020

Motivation for this change

While compiling, glibmm tries to execute glib-compile-schemas, which
requires glib to be in the nativeBuildInputs for cross-platform builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka kampka added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Sep 1, 2020
@kampka
Copy link
Contributor Author

kampka commented Sep 1, 2020

@GrahamcOfBorg build glibmm
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.glibmm

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from 7c6f434c September 1, 2020 22:49
@kampka
glibmm: Add glib to nativeBuildInputs
7332051 
While compiling, glibmm tries to execute glib-compile-schemas, which
requires glib to be in the nativeBuildInputs for cross-platform builds.
@kampka
Copy link
Contributor Author

kampka commented Sep 2, 2020

@GrahamcOfBorg build glibmm
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.glibmm

@kampka kampka requested a review from jtojnar September 2, 2020 10:31
@jtojnar jtojnar merged commit 0d83d01 into NixOS:staging Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @jonringer @jtojnar