gamin: Fix cross compiling issues #96903
Conversation
kampka
added
the
6.topic: cross-compilation
|
@GrahamcOfBorg build gamin |
|
@GrahamcOfBorg eval |
| - [have_abstract_sockets=no]) | ||
| -AC_LANG_POP(C) | ||
| -AC_MSG_RESULT($have_abstract_sockets) | ||
| +have_abstract_sockets=yes |
There was a problem hiding this comment.
you should be able to use $host_os and AC_CANONICAL_HOST to get the right value here, avoiding the need for two patches
There was a problem hiding this comment.
Good point. I am not very familiar with the whole autotools toolschain, so I appreciate reviews like these 👍
The build already has $target_os which should be good for this case, though I cannot test it against Darwin.
|
Thanks for the contribution. Is there something specific you need gamin for? I would rather just drop this package since upstream is dead and we would have to maintain our fork here. |
No, it just comes up in the dependency chain of my configuration, probably through the |
Gamin fails to build cross-platform because it tries to run AC_RUN_IFELSE during configure which fails as the test program is built for the wrong platform and cannot execute. Since the test is only for the 'abstract socket namespace' feature, we can just pin the results for out builds, it is 'yes' for Linux and 'no' for Darwin (and other BSD).
|
@GrahamcOfBorg build gamin |
Motivation for this change
Gamin fails to build cross-platform because it tries to run
AC_RUN_IFELSE during configure which fails as the test program is built
for the wrong platform and cannot execute. Since the test is only for
the 'abstract socket namespace' feature, we can just pin the results
for out builds, it is 'yes' for Linux and 'no' for Darwin (and other
BSD).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)