Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparkleshare: init at 3.28 #96875

Merged
merged 5 commits into from Sep 1, 2020
Merged

sparkleshare: init at 3.28 #96875

merged 5 commits into from Sep 1, 2020

Conversation

kevincox
Copy link
Contributor

Note: This change includes adding and fixing some dependencies in separate commits. If preferred I can submit them as separate PRs.

Motivation for this change

Make sparkleshare available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kevincox kevincox self-assigned this Aug 31, 2020
Copy link
Contributor

@OmnipotentEntity OmnipotentEntity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs. Diff looks good. I was a little sus on the direct hash revision for appindicator-sharp and webkit2-sharp. However, both of these repos do not have tags.

Thanks for fixing notify-sharp and libgnomeui as well. The github links no longer seem to exist.

@kevincox
Copy link
Contributor Author

kevincox commented Sep 1, 2020

Yeah, it would be nice if those projects could mark a release, however I couldn't find any sort of official version anywhere so I figured that the tip of master is the best bet 🤷‍♀️ I'll raise issues with the individual projects so that we can update it in the future.

@kevincox kevincox merged commit 2cd9dd5 into master Sep 1, 2020
@kevincox kevincox deleted the kevincox-sparkleshare branch September 1, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants