Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.transformers: 3.0.2 -> 3.1.0 #96907

Merged
merged 1 commit into from Sep 1, 2020
Merged

python3Packages.transformers: 3.0.2 -> 3.1.0 #96907

merged 1 commit into from Sep 1, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 1, 2020

Motivation for this change

Transformers now has nlp as an optional dependency. nlp will
require some work to package, since it attempts to download modules
into its Python package path by default. So, the nlp-based test
is disable for the time being.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
python3Packages.transformers: 3.0.2 -> 3.1.0
b0806a5 
Transformers now has `nlp` as an optional dependency. `nlp` will
require some work to package, since it attempts to download modules
into its Python package path by default. So, the `nlp`-based test
is disable for the time being.
jonringer
jonringer approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96907 1

2 packages built:
- python37Packages.transformers
- python38Packages.transformers

@jonringer jonringer merged commit 2fb0ad3 into NixOS:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @jonringer