Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/sssd-ldap: init #96885

Merged
merged 1 commit into from Sep 6, 2020
Merged

nixos/tests/sssd-ldap: init #96885

merged 1 commit into from Sep 6, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 1, 2020

He's a very basic sssd test with ldap. It doesn't test auth but it does test getent passwd <username>.

This could maybe be used as a base for more advanced tests like for gdm, sddm, ssh...

I hope this test doesn't share any of the problem that the removed test had.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbigras bbigras mentioned this pull request Sep 1, 2020
Open
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/286

Mic92
Mic92 reviewed Sep 3, 2020
View reviewed changes
nixos/tests/sssd-ldap.nix Outdated
rootdn = "cn=${ldapRootUser},${dbSuffix}";
rootpw = ldapRootPassword;
suffix = dbSuffix;
declarativeContents = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to migrate this once #94610 by @kwohlfahrt is merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But not a big deal.

Mic92
Mic92 reviewed Sep 3, 2020
View reviewed changes
nixos/tests/sssd-ldap.nix Outdated Show resolved Hide resolved
@bbigras
Copy link
Contributor Author

bbigras commented Sep 4, 2020

For simplicity/speed do you think is needed to have two VMs running?

You are right, I fixed it.

@Mic92 Mic92 merged commit d9ccdd8 into NixOS:master Sep 6, 2020
@bbigras bbigras deleted the sssd-ldap branch September 7, 2020 18:36
@bbigras
Copy link
Contributor Author

bbigras commented Sep 7, 2020

Thanks @Mic92 !!

@kwohlfahrt kwohlfahrt mentioned this pull request Sep 13, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @nixos-discourse @Mic92