Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs-cluster: pin to go 1.14 #96891

Merged
merged 1 commit into from Sep 1, 2020
Merged

ipfs-cluster: pin to go 1.14 #96891

merged 1 commit into from Sep 1, 2020

Conversation

AluisioASG
Copy link
Contributor

@AluisioASG AluisioASG commented Sep 1, 2020 •
edited

Motivation for this change

Another one broken on Go 1.15.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AluisioASG AluisioASG marked this pull request as ready for review September 1, 2020 07:41
@AluisioASG
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer
cc @jglukasik

@marvin-mk2
Copy link

marvin-mk2 bot commented Sep 1, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

zowoq
zowoq approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zowoq zowoq merged commit 2316f35 into NixOS:master Sep 1, 2020
@AluisioASG AluisioASG deleted the aasg/ipfs-cluster-go1.14 branch September 1, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AluisioASG @zowoq