Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/qemu-vm: Fix and update system.requiredKernelConfig entries #96912

Merged
merged 3 commits into from Nov 11, 2020

Conversation

atlaua
Copy link
Contributor

@atlaua atlaua commented Sep 1, 2020

Motivation for this change

The system.requiredKernelConfig setting in the qemu-vm module is currently both broken and outdated in various ways. Details are provided in the individual commits.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Sep 6, 2020

might interest you #69013

@atlaua atlaua force-pushed the aranea/qemu-vm-kernel-config branch from e37b586 to 63a29fe Compare October 30, 2020 20:13
'optional' just takes a single item rather than a list
The kernel stopped using this config option with version 3.9 (back in
2013!).
Verify that all kernel modules which are required for mounting
/nix/store in the VM are present.
@atlaua atlaua force-pushed the aranea/qemu-vm-kernel-config branch from 63a29fe to a7de454 Compare October 30, 2020 21:23
@atlaua
Copy link
Contributor Author

atlaua commented Oct 30, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 30, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 30, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@kevincox kevincox merged commit dce7cc1 into NixOS:master Nov 11, 2020
@atlaua atlaua deleted the aranea/qemu-vm-kernel-config branch November 15, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants