Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hspell: fix cross-platform build issues #96896

Merged
merged 1 commit into from Jan 17, 2021
Merged

hspell: fix cross-platform build issues #96896

merged 1 commit into from Jan 17, 2021

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Sep 1, 2020

Motivation for this change

hspell uses a couple of binaries it generates during it's own build.
These will cause the build to fail later in cross-platform builds as
these binaries have the wrong executable format.
Using a hspell to bootstrap it's own build natively resolves this issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka kampka added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Sep 1, 2020
@kevincox
Copy link
Contributor

kevincox commented Sep 1, 2020

I notice that this doesn't have a maintainer listed. Would you be interested in taking it over?

@kampka
Copy link
Contributor Author

kampka commented Sep 1, 2020

I notice that this doesn't have a maintainer listed. Would you be interested in taking it over?

Sure, added myself as a maintainer, but in all fairness, I'm not passionate about this at all.
I mainly fixed the issue because the package is in the build chain of something else I am trying to cross-build.
Since this package seems low-maintenance without new releases in quite a while, I can probably keep an eye on it though it won't become a priority.

@kampka
Copy link
Contributor Author

kampka commented Sep 1, 2020

@GrahamcOfBorg build hspell
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.hspell

@kampka kampka changed the base branch from master to staging September 1, 2020 12:53
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@kampka
hspell: fix cross-platform build issues
67f0a21 
hspell uses a couple of binaries it generates during it's own build.
These will cause the build to fail later in cross-platform builds as
these binaries have the wrong executable format.
Using a hspell to bootstrap it's own build natively resolves this issue.
@kampka
Copy link
Contributor Author

kampka commented Sep 2, 2020

@GrahamcOfBorg build hspell
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.hspell

@Ericson2314
Copy link
Member

Is there any way to contribute patches upstream or is this project pure cathedral style?

@kampka
Copy link
Contributor Author

kampka commented Sep 2, 2020

Is there any way to contribute patches upstream or is this project pure cathedral style?

I am neither familiar with the term cathedral style nor the project, really.
Could you clarify what you mean?

@alyssais
Copy link
Member

alyssais commented Sep 7, 2020

I am neither familiar with the term cathedral style nor the project, really.

Cathedral style means software that is open source, but largely or entirely directed by one person or group. It’s less about whether they accept outside patches, but more about whether outsiders can be part of changing how the program works or coming up with its overall direction. The term comes from a famous essay about open source software development called The Cathedral and the Bazaar.

@kampka
Copy link
Contributor Author

kampka commented Sep 7, 2020

Cathedral style means software that is open source, but largely or entirely directed by one person or group. It’s less about whether they accept outside patches, but more about whether outsiders can be part of changing how the program works or coming up with its overall direction. The term comes from a famous essay about open source software development called The Cathedral and the Bazaar.

Got it, thanks for clarifying.

@zowoq zowoq removed their request for review September 10, 2020 10:05
@jtojnar
Copy link
Contributor

jtojnar commented Sep 11, 2020

I tried updating the package to the latest version:

https://github.com/jtojnar/nixpkgs/pull/new/hspell-1.4

Could you please try if the situation is not better there?

@kampka
Copy link
Contributor Author

kampka commented Sep 11, 2020

I tried updating the package to the latest version:

https://github.com/jtojnar/nixpkgs/pull/new/hspell-1.4

Could you please try if the situation is not better there?

I tried that already, but it not only has the same issues, it actually introduces new ones when linking against zlib that I don't currently have the time to figure out.

@symphorien
Copy link
Member

@GrahamcOfBorg build hspell
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.hspell

@symphorien symphorien merged commit 5ca647b into NixOS:staging Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

@nbp nbp Awaiting requested review from nbp

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kampka @kevincox @jonringer @Ericson2314 @alyssais @jtojnar @symphorien @matthewbauer