Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] adobe-reader: add knownVulnerabilities #96893

Merged
merged 1 commit into from Sep 3, 2020
Merged

[20.03] adobe-reader: add knownVulnerabilities #96893

merged 1 commit into from Sep 3, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 1, 2020

Motivation for this change

We should really avoid that people unknowingly use Adobe Reader, it
has literally tens of known high-score code execution vulnerabilities,
probably exploited in the wild.

(cherry picked from commit 4b07b00)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
adobe-reader: add knownVulnerabilities
0ee482c 
We should really avoid that people unknowingly use Adobe Reader, it
has literally tens of known high-score code execution vulnerabilities,
probably exploited in the wild.

(cherry picked from commit 4b07b00)
@mweinelt
Copy link
Member

mweinelt commented Sep 1, 2020

We should probably indicate that Adobe is not maintaing the Linux version of the Reader anymore and that this is the last version. Therefore no fixes can be expected.

@danieldk
Copy link
Contributor Author

danieldk commented Sep 1, 2020

We should probably indicate that Adobe is not maintaing the Linux version of the Reader anymore and that this is the last version. Therefore no fixes can be expected.

Or maybe we should say that it will be removed at some future date? (when?) It probably does not make much sense to keep these old, unmaintained proprietary projects. If someone really needs it, they could add it to the NUR or make a flake.

@vcunat
Copy link
Member

vcunat commented Sep 1, 2020

Yes, probably remove, after some time in the "vulnerable" state... though not on 20.03.

@vcunat vcunat merged commit d92de0e into NixOS:release-20.03 Sep 3, 2020
@vcunat
Copy link
Member

vcunat commented Sep 3, 2020

Let's not wait anymore. Merging doesn't prevent further improvements to the message, etc. (first in master, though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @mweinelt @vcunat