Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

top-level: fix nix-shell eval w/nixUnstable #97807

Merged
merged 1 commit into from Sep 14, 2020
Merged

top-level: fix nix-shell eval w/nixUnstable #97807

merged 1 commit into from Sep 14, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 11, 2020

Motivation for this change

For a full description of the underlying issue please read
NixOS/nix#4003

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
top-level: fix nix-shell eval w/nixUnstable
fa6064a 
For a full description of the underlying issue please read
NixOS/nix#4003
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 11, 2020
@Ma27
Copy link
Member Author

Ma27 commented Sep 11, 2020

Note: IMHO we should backport this to 20.09 and 20.03 to allow users of nixUnstable to use nix-shell on their nixpkgs checkouts.

@Ma27 Ma27 mentioned this pull request Sep 11, 2020
Closed
@Ma27 Ma27 merged commit 2a7e3bc into NixOS:master Sep 14, 2020
@Ma27 Ma27 deleted the fix-nix-shell-eval branch September 14, 2020 07:10
@Ma27
Copy link
Member Author

Ma27 commented Sep 14, 2020

Backported to 20.03 as 732684b, to 20.09 as c1dbaed.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 14, 2020
@drewrisinger drewrisinger mentioned this pull request Sep 14, 2020
Merged
10 tasks
@cole-h cole-h mentioned this pull request Oct 1, 2020
Merged
10 tasks
@nh2
Copy link
Contributor

nh2 commented Nov 19, 2021 •
edited

I just upgraded to nix 2.4 stable and found this issue when trying to reproduce a nixpkgs 20.03 build (from before the backport patch).

It is quite unfortunate that with nix >= 2.4, you cannot reproduce old builds at all now, because they don't evaluate, breaking the reproducibility story.

Is there something that could be done in nix to make that possible?

@andir
Copy link
Member

andir commented Nov 29, 2021

I'm trying to fix that over here but that isn't as straight forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @nh2 @andir