Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] jackmix, jackmix_jack1: fix build, add alsaLib dependency #97843

Merged
merged 1 commit into from Sep 12, 2020
Merged

[20.09] jackmix, jackmix_jack1: fix build, add alsaLib dependency #97843

merged 1 commit into from Sep 12, 2020

Conversation

freezeboy
Copy link
Contributor

(cherry picked from commit 6dafaa5)

Motivation for this change

initial PR: #97753

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
Copy link
Member

zimbatm commented Sep 12, 2020

Result of nixpkgs-review pr 97843 1

2 packages built:
  • jackmix
  • jackmix_jack1

@zimbatm zimbatm merged commit 37fd028 into NixOS:release-20.09 Sep 12, 2020
@freezeboy freezeboy deleted the backport-jackmix branch September 13, 2020 05:20
@avdv avdv mentioned this pull request May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @zimbatm