Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zulip-term: init at 0.5.2 #97817

Merged
merged 3 commits into from Sep 12, 2020
Merged

zulip-term: init at 0.5.2 #97817

merged 3 commits into from Sep 12, 2020

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

teto
teto reviewed Sep 12, 2020
View reviewed changes
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed nixpkgs-review. Could start the binary but didn't test login in a chatroom as my IDs got refused. (I use the connect by github usually, is that possible thorugh the client ?).

pkgs/applications/networking/instant-messengers/zulip-term/pytest-executable-name.patch
assert str(e.value) == "2"
captured = capsys.readouterr()
lines = captured.err.strip('\n')
- lines = lines.split("pytest: ", 1)[1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any plan to upstream ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered it, but I think the name is specific to our pytest infrastructure. I could split it using some regex.

@teto teto merged commit 8d25f83 into NixOS:master Sep 12, 2020
@dotlambda dotlambda deleted the zulip-terminal branch September 12, 2020 16:06
@dotlambda
Copy link
Member Author

dotlambda commented Sep 12, 2020 •
edited

Could start the binary but didn't test login in a chatroom as my IDs got refused. (I use the connect by github usually, is that possible thorugh the client ?).

See https://github.com/zulip/zulip-terminal#running-for-the-first-time. I just downloaded zuliprc from my account settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @teto