Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.holidays: fix build by adding korean-lunar-calendar dependency #97845

Merged
merged 2 commits into from Sep 14, 2020
Merged

pythonPackages.holidays: fix build by adding korean-lunar-calendar dependency #97845

merged 2 commits into from Sep 14, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 12, 2020 •
edited

Motivation for this change

ZHF: #97479

holidays 0.10.3 is failing because it requires a new dependency which we don't yet have packaged.

And this is how I end up the maintainer of packages like korean-lunar-calendar.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jluttine September 12, 2020 15:19
drewrisinger
drewrisinger suggested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

Mostly LGTM, minor style points.

  • Diff style improvements
  • Commits LGTM
  • Haven't attempted build yet.

pkgs/development/python-modules/holidays/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/holidays/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/korean-lunar-calendar/default.nix Show resolved Hide resolved
pkgs/development/python-modules/korean-lunar-calendar/default.nix Show resolved Hide resolved
drewrisinger
drewrisinger approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review on Linux-x86_64
3 packages added:
python27Packages.korean-lunar-calendar (init at 0.2.1) python37Packages.korean-lunar-calendar (init at 0.2.1) python38Packages.korean-lunar-calendar (init at 0.2.1)

3 packages updated:
python2.7-holidays python3.7-holidays python3.8-holidays

@risicle risicle merged commit 58802be into NixOS:master Sep 14, 2020
@risicle risicle mentioned this pull request Sep 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@jluttine jluttine Awaiting requested review from jluttine

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @drewrisinger