Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] Fixes for python3.pkgs.{jedi,python-language-server,engineio} #97809

Merged
merged 4 commits into from Sep 13, 2020
Merged

[20.09] Fixes for python3.pkgs.{jedi,python-language-server,engineio} #97809

merged 4 commits into from Sep 13, 2020

Conversation

vlaci
Copy link
Contributor

@vlaci vlaci commented Sep 11, 2020

Motivation for this change

backport of #97209

ZHF: #97479

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Sep 11, 2020

Could you include references to the commits on master that these are cherry-picks of in the commit messages? (As you get when using cherry-pick's -x flag)

@Mic92
python-engineio: 3.13.0 -> 3.13.2 (fix build)
8240583 
(cherry picked from commit 12fc3e0)
@Mic92
python3.pkgs.python-language-server: 0.33.1 -> 0.34.1
77816d6 
(cherry picked from commit b0a8c8a)
@Mic92
python3.pkgs.jedi: fix compatibility with parso
a3a4551 
The current version is fundamentally broken as tested with
python-language-server because parso now uses Path instead of str
in many instances.

Backporting of the fixes is not trivial and likely breaks more stuff
than it fixes due to other refactorings in jedi, hence using a recent
commit in master seems more reasonably.

(cherry picked from commit 12a9a93)
@Mic92
python3.pkgs.python-language-server: fix jedi integration
15a8e66 
recent jedi/parso versions uses Path instead of str.

(cherry picked from commit b99096b)
@vlaci
Copy link
Contributor Author

vlaci commented Sep 11, 2020

Could you include references to the commits on master that these are cherry-picks of in the commit messages? (As you get when using cherry-pick's -x flag)

Sorry for forgetting the -x flag. Commits amended

@ofborg ofborg bot requested a review from Mic92 September 12, 2020 00:55
jonringer
jonringer approved these changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonringer jonringer merged commit 39dfaa4 into NixOS:release-20.09 Sep 13, 2020
@vlaci vlaci deleted the 20.09-python-fixes branch July 31, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vlaci @risicle @jonringer @Mic92