Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnetCorePackages.sdk_5_0: init at version 5.0.100-preview.8.20417.9 #97806

Merged
merged 3 commits into from Sep 25, 2020
Merged

dotnetCorePackages.sdk_5_0: init at version 5.0.100-preview.8.20417.9 #97806

merged 3 commits into from Sep 25, 2020

Conversation

JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Sep 11, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JamieMagee @felschr
dotnetCorePackages.sdk_5_0: init at version 5.0.100-rc.1.20452.10
074e05c 
Co-authored-by: Felix Tenley <felschr@pm.me>
felschr
felschr reviewed Sep 19, 2020
View reviewed changes
Copy link
Member

@felschr felschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure about this but there seems generally no reason against including preview releases in nixpkgs.
Considering that .NET 5 is in the final stages of development personally I'd approve.

@JamieMagee
Copy link
Member Author

Thanks. Yeah, I know it's close to GA.

I've missed the 20.09 cutoff, but I figure it'll be GA in time for 21.03, and it does no harm being in unstable in the meantime.

felschr
felschr approved these changes Sep 19, 2020
View reviewed changes
Copy link
Member

@felschr felschr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux
Comments

PR title should be updated.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/233

@AndersonTorres
Copy link
Member

Is there someone allocated for dotnet infrastructure?

@AndersonTorres AndersonTorres merged commit 4e297bd into NixOS:master Sep 25, 2020
@JamieMagee
Copy link
Member Author

@AndersonTorres From the git history it looks like @jonringer & @nyanloutre are the best people to review these PRs in future.

@JamieMagee JamieMagee deleted the dotnet-sdk-5.0 branch September 25, 2020 11:57
@jonringer
Copy link
Contributor

Yea, I've been kind of following the dotnet scene...

I'm using it again for work. So I might take some time to "make it nice" to use.

@jonringer
Copy link
Contributor

also, IIRC, dotnet 5 is supposed to unify all of the various dotnet frameworks. If a stable release of dotnet5 comes out, we might want to make it the default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felschr felschr felschr approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JamieMagee @nixos-discourse @AndersonTorres @jonringer @felschr