vimPlugins.presenting-vim: init at 2018-11-25 #97877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meithecatte
reviewed
Sep 13, 2020
pkgs/misc/vim-plugins/generated.nix
Outdated
Comment on lines
138
to
149
| asyncomplete-vim = buildVimPluginFrom2Nix { | ||
| pname = "asyncomplete-vim"; | ||
| version = "2020-08-09"; | ||
| src = fetchFromGitHub { | ||
| owner = "prabirshrestha"; | ||
| repo = "asyncomplete.vim"; | ||
| rev = "0d4ec1805d50fd39b8b41626e0761736feb307d0"; | ||
| sha256 = "0lcqdh51fd8lx1g02dcwrfnnx3zfm71g57nv2pmin5ap7qgh8kir"; | ||
| }; | ||
| meta.homepage = "https://github.com/prabirshrestha/asyncomplete.vim/"; | ||
| }; | ||
|
|
There was a problem hiding this comment.
What is the reasoning behind removing this package?
There was a problem hiding this comment.
This was done by update.py. It looks like the package has a new owner on GitHub, and the update.py script follows redirect links. A recent PR I made for vimPlugins featured the same update.
There was a problem hiding this comment.
Hmm the package has not moved from https://github.com/prabirshrestha/asyncomplete.vim, and I did not make this change. I'll re-run the script 🤞
There was a problem hiding this comment.
Yes that looks to be the issue. Good eye. It was not included in vim-plugin-names.
There was a problem hiding this comment.
I addressed this issue, PTAL.
kalbasit
force-pushed
the
init-presenting-vim
branch
from
d61ab35
to
7222963
Compare
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/sotte/presenting.vim
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)