Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeek: Fix zeek script coreutils and hardlinking #97813

Merged
merged 1 commit into from Sep 21, 2020

Conversation

GTrunSec
Copy link
Contributor

@GTrunSec GTrunSec commented Sep 11, 2020

Motivation for this change
  • replacing /bin/* to coreutils path
  • fix tunnel script duplicated hardlink
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GTrunSec
Copy link
Contributor Author

GTrunSec commented Sep 19, 2020

@pSub Thanks for reviewing. the PR will be fixed some Zeek's internal scripts issues.

@marsam marsam merged commit 49bf89f into NixOS:master Sep 21, 2020
@marsam
Copy link
Contributor

marsam commented Sep 21, 2020

Thanks! sorry for the delay

@GTrunSec GTrunSec deleted the zeek-script branch September 30, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants