Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.minio: fix cred tests #97824

Merged
merged 1 commit into from Sep 13, 2020
Merged

[20.09] python3Packages.minio: fix cred tests #97824

merged 1 commit into from Sep 13, 2020

Conversation

wkral
Copy link
Contributor

@wkral wkral commented Sep 12, 2020

(cherry picked from commit 9716fcd)

Motivation for this change

Went to go fix this, but found it already fixed in master.
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wkral
Copy link
Contributor Author

wkral commented Sep 12, 2020

Result of nixpkgs-review pr 97824 1

1 package failed to build:
  • python37Packages.rl-coach
3 packages built:
  • python37Packages.minio
  • python38Packages.minio
  • sourcehut.gitsrht

@risicle
Copy link
Contributor

risicle commented Sep 13, 2020 •
edited

WFM macos 10.14

@ofborg build python37Packages.minio python38Packages.minio

@risicle risicle merged commit e0508c8 into NixOS:release-20.09 Sep 13, 2020
@wkral wkral deleted the backport-python-minio-test-fix branch September 14, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wkral @risicle @jonringer