Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.python-snap7: init 0.11 #97881

Merged
merged 1 commit into from Sep 13, 2020
Merged

python3Packages.python-snap7: init 0.11 #97881

merged 1 commit into from Sep 13, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Sep 13, 2020 •
edited

Motivation for this change

New package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy freezeboy force-pushed the add-python-snap7 branch 3 times, most recently from eb1acf8 to 108d3cb Compare September 13, 2020 04:16
jonringer
jonringer reviewed Sep 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/python-snap7/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97881 1

3 packages built:
  • python27Packages.python-snap7
  • python37Packages.python-snap7
  • python38Packages.python-snap7

@jonringer jonringer merged commit 7849d11 into NixOS:master Sep 13, 2020
@freezeboy freezeboy deleted the add-python-snap7 branch September 13, 2020 17:55
@freezeboy freezeboy mentioned this pull request Sep 13, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @jonringer