Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zenith: 0.10.0 -> 0.10.1 #97860

Merged
merged 1 commit into from Sep 13, 2020
Merged

zenith: 0.10.0 -> 0.10.1 #97860

merged 1 commit into from Sep 13, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 12, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/cp0wngf83ryhvnsx1ybja66kdip7wiz8-zenith-0.10.0 34.1M
/nix/store/d6r9rnryjlxdld21g1n3bffcqxh36bda-zenith-0.10.1 33.6M

@marsam
Copy link
Contributor

marsam commented Sep 13, 2020

would you mind removing the platforms from meta? the issue referenced is closed

@bbigras
Copy link
Contributor Author

bbigras commented Sep 13, 2020

@GrahamcOfBorg build zenith

@bbigras
Copy link
Contributor Author

bbigras commented Sep 13, 2020

would you mind removing the platforms from meta? the issue referenced is closed

done. thanks

@bbigras
Copy link
Contributor Author

bbigras commented Sep 13, 2020

It looks like it still doesn't build on aarch64 so I put back the platforms part.

I did a PR to fix it once #88616 but I gave up because of lack of interest. Feel free to reimplement it.

@marsam marsam merged commit b441d09 into NixOS:master Sep 13, 2020
@marsam
Copy link
Contributor

marsam commented Sep 13, 2020

I see, thanks anyway.

@bbigras bbigras deleted the zenith branch September 13, 2020 14:07
@bbigras
Copy link
Contributor Author

bbigras commented Sep 13, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbigras @marsam