Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.nerdtree-git-plugin: init at 2020-09-11 #97851

Closed
wants to merge 2 commits into from
Closed

vimPlugins.nerdtree-git-plugin: init at 2020-09-11 #97851

wants to merge 2 commits into from

Conversation

zachcoyle
Copy link
Contributor

@zachcoyle zachcoyle commented Sep 12, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zachcoyle
Copy link
Contributor Author

zachcoyle commented Sep 12, 2020 •
edited

nerdtree-git-plugin already existed in the vimPlugins, but it was pointing to an old, unmaintained fork which recently broke with an update to NERDTree

@ofborg ofborg bot requested review from jorsn and jagajaga September 12, 2020 18:59
@zachcoyle zachcoyle closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@jorsn jorsn Awaiting requested review from jorsn

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: vim 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zachcoyle @ryantm