nix-repl: use history file #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
leungbk
commented
Sep 12, 2020
leungbk
commented
leungbk
force-pushed
the
repl-history
branch
2 times, most recently
from
33fea48
to
b89a38b
Compare
nix-repl.el
Outdated
| (define-derived-mode nix-repl-mode comint-mode "Nix-REPL" | ||
| "Interactive prompt for Nix." | ||
| (setq-local comint-prompt-regexp nix-prompt-regexp) | ||
| (setq-local comint-prompt-read-only t) | ||
| (let* ((is-remote (file-remote-p default-directory)) | ||
| (maybe-xdg-data-home (shell-command-to-string "echo -n $XDG_DATA_HOME")) |
There was a problem hiding this comment.
use getenv to avoid a subprocess
There was a problem hiding this comment.
OK, I used getenv for non-remote. I don't really know how things work in remote settings; I saw that Emacs' shell.el used a subprocess for remote settings and getenv for local settings:
(when remote
;; `shell-snarf-envar' does not work trustworthy.
(setq hsize (shell-command-to-string "echo -n $HISTSIZE")
hfile (shell-command-to-string "echo -n $HISTFILE")))So I updated this patch to do the same thing. Is that the right way of doing this?
leungbk
force-pushed
the
repl-history
branch
from
b89a38b
to
c81c03b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.