Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_1password-gui: 0.8.4 -> 0.8.5-1 #97852

Merged
merged 1 commit into from Sep 14, 2020
Merged

_1password-gui: 0.8.4 -> 0.8.5-1 #97852

merged 1 commit into from Sep 14, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changes:

https://discussions.agilebits.com/discussion/115658/1password-development-preview-0-8-5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endocrimes
Copy link
Member

Result of nixpkgs-review pr 97852 1

1 package built:
  • _1password-gui

endocrimes
endocrimes approved these changes Sep 13, 2020
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the resulting binary locally and everything seems to be functional 👍

@danieldk
Copy link
Contributor Author

@endocrimes thanks for the review!

@danieldk danieldk merged commit d2098f9 into NixOS:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @endocrimes