Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: remove unnecessary protobof version pin #97867

Closed
wants to merge 1 commit into from
Closed

home-assistant: remove unnecessary protobof version pin #97867

wants to merge 1 commit into from

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Sep 12, 2020 •
edited

Motivation for this change

When esphome is used with home-assistant the build will fail because of the protobuf version pin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Sorry, I missed this. I pushed #97870 and #97874 respectively already.

@mweinelt mweinelt closed this Sep 13, 2020
@nyanloutre nyanloutre deleted the home_assist_esphome branch September 13, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyanloutre @mweinelt